Commit fa2b7c21 authored by Robert Foss's avatar Robert Foss Committed by Gerd Hoffmann
Browse files

drm/virtio: Remove redundant return type 



virtio_gpu_fence_emit() always returns 0, since it
has no error paths.

Consequently no calls for virtio_gpu_fence_emit()
use the return value, and it can be removed.

Signed-off-by: default avatarRobert Foss <robert.foss@collabora.com>
Reviewed-by: default avatarChia-I Wu <olvaffe@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20190506091034.30289-1-robert.foss@collabora.com


Suggested-by: default avatarEmil Velikov <emil.velikov@collabora.com>
Reviewed-by: default avatarChia-I Wu <olvaffe@gmail.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 9c79edec

drivers/gpu/drm/virtio/virtgpu_drv.h

+1 −1
Original line number Diff line number Diff line
@@ -355,7 +355,7 @@ int virtio_gpu_mmap(struct file *filp, struct vm_area_struct *vma); 
bool virtio_fence_signaled(struct dma_fence *f);

struct virtio_gpu_fence *virtio_gpu_fence_alloc(

	struct virtio_gpu_device *vgdev);

int virtio_gpu_fence_emit(struct virtio_gpu_device *vgdev,

void virtio_gpu_fence_emit(struct virtio_gpu_device *vgdev,

			  struct virtio_gpu_ctrl_hdr *cmd_hdr,

			  struct virtio_gpu_fence *fence);

void virtio_gpu_fence_event_process(struct virtio_gpu_device *vdev,

drivers/gpu/drm/virtio/virtgpu_fence.c

+1 −2
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ struct virtio_gpu_fence *virtio_gpu_fence_alloc(struct virtio_gpu_device *vgdev) 
	return fence;

}



int virtio_gpu_fence_emit(struct virtio_gpu_device *vgdev,

void virtio_gpu_fence_emit(struct virtio_gpu_device *vgdev,

			  struct virtio_gpu_ctrl_hdr *cmd_hdr,

			  struct virtio_gpu_fence *fence)

{
@@ -102,7 +102,6 @@ int virtio_gpu_fence_emit(struct virtio_gpu_device *vgdev, 


	cmd_hdr->flags |= cpu_to_le32(VIRTIO_GPU_FLAG_FENCE);

	cmd_hdr->fence_id = cpu_to_le64(fence->f.seqno);

	return 0;

}



void virtio_gpu_fence_event_process(struct virtio_gpu_device *vgdev,

CRA Git | Maintained and supported by SUSTech CRA and CCSE