pstore: no need to check return value of debugfs_create functions (fa1af758) · Commits · 戴 / test

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Kees Cook <keescook@chromium.org> Cc: Anton Vorontsov <anton@enomsg.org> Cc: Colin Cross <ccross@android.com> Cc: Tony Luck <tony.luck@intel.com> Cc: linux-kernel@vger.kernel.org Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:

Kees Cook <keescook@chromium.org>

fs/pstore/ftrace.c

+2 −16

Original line number	Original line	Diff line number	Diff line
	@@ -112,27 +112,13 @@ static struct dentry *pstore_ftrace_dir;

	void pstore_register_ftrace(void)		void pstore_register_ftrace(void)
	{		{
	struct dentry *file;

	if (!psinfo->write)		if (!psinfo->write)
	return;		return;

	pstore_ftrace_dir = debugfs_create_dir("pstore", NULL);		pstore_ftrace_dir = debugfs_create_dir("pstore", NULL);
	if (!pstore_ftrace_dir) {
	pr_err("%s: unable to create pstore directory\n", __func__);
	return;
	}

	file = debugfs_create_file("record_ftrace", 0600, pstore_ftrace_dir,		debugfs_create_file("record_ftrace", 0600, pstore_ftrace_dir, NULL,
	NULL, &pstore_knob_fops);		&pstore_knob_fops);
	if (!file) {
	pr_err("%s: unable to create record_ftrace file\n", __func__);
	goto err_file;
	}

	return;
	err_file:
	debugfs_remove(pstore_ftrace_dir);
	}		}

	void pstore_unregister_ftrace(void)		void pstore_unregister_ftrace(void)

Admin message