Commit fa1195cc authored Jan 09, 2018 by Jiri Olsa Committed by Arnaldo Carvalho de Melo Jan 12, 2018

perf tools: Fix copyfile_offset update of output offset



We need to increase output offset in each iteration, not decrease it as
we currently do.

I guess we were lucky to finish in most cases in first iteration, so the
bug never showed. However it shows a lot when working with big (~4GB)
size data.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: 9c9f5a2f ("perf tools: Introduce copyfile_offset() function")
Link: http://lkml.kernel.org/r/20180109133923.25406-1-jolsa@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 236d812c

tools/perf/util/util.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -210,7 +210,7 @@ static int copyfile_offset(int ifd, loff_t off_in, int ofd, loff_t off_out, u64

		size -= ret;
		off_in += ret;
		off_out -= ret;
		off_out += ret;
		}
		munmap(ptr, off_in + size);

Admin message