Commit fa09d065 authored Dec 07, 2018 by Ondrej Jirman Committed by Mauro Carvalho Chehab Dec 12, 2018

media: v4l2-fwnode: Fix setting V4L2_MBUS_DATA_ACTIVE_HIGH/LOW flag



When parallel bus is used and data-active is being parsed, incorrect
flags are cleared.

Clear the correct flag bits.

Fixes: e9be1b86 (media: v4l: fwnode:
Use default parallel flags).

Cc: stable@vger.kernel.org # for Kernel 4.20
Signed-off-by: Ondrej Jirman <megous@megous.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent d2b4387f

drivers/media/v4l2-core/v4l2-fwnode.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -310,8 +310,8 @@ v4l2_fwnode_endpoint_parse_parallel_bus(struct fwnode_handle *fwnode,
		}

		if (!fwnode_property_read_u32(fwnode, "data-active", &v)) {
		flags &= ~(V4L2_MBUS_PCLK_SAMPLE_RISING \|
		V4L2_MBUS_PCLK_SAMPLE_FALLING);
		flags &= ~(V4L2_MBUS_DATA_ACTIVE_HIGH \|
		V4L2_MBUS_DATA_ACTIVE_LOW);
		flags \|= v ? V4L2_MBUS_DATA_ACTIVE_HIGH :
		V4L2_MBUS_DATA_ACTIVE_LOW;
		pr_debug("data-active %s\n", v ? "high" : "low");

Admin message