Commit fa00e106 authored Dec 01, 2009 by Dan Carpenter Committed by Linus Torvalds Dec 01, 2009

drivers/rtc/rtc-pcf50633.c: fix use after free in pcf50633_rtc_probe()



"rtc" is freed and then dereferenced on the next line.  This patch fixes
that.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
Cc: David Brownell <david-b@pacbell.net>
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 4c4cb1b1

drivers/rtc/rtc-pcf50633.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -292,8 +292,9 @@ static int __devinit pcf50633_rtc_probe(struct platform_device *pdev)
		&pcf50633_rtc_ops, THIS_MODULE);

		if (IS_ERR(rtc->rtc_dev)) {
		int ret = PTR_ERR(rtc->rtc_dev);
		kfree(rtc);
		return PTR_ERR(rtc->rtc_dev);
		return ret;
		}

		pcf50633_register_irq(rtc->pcf, PCF50633_IRQ_ALARM,

Admin message