hwmon: (asus_atk0110) Fix debugfs_simple_attr.cocci warnings (f9facc24) · Commits · 戴 / test

Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by:

YueHaibing <yuehaibing@huawei.com> Signed-off-by:

Guenter Roeck <linux@roeck-us.net>

drivers/hwmon/asus_atk0110.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -681,9 +681,7 @@ static int atk_debugfs_gitm_get(void p, u64 val)
		return err;
		}

		DEFINE_SIMPLE_ATTRIBUTE(atk_debugfs_gitm,
		atk_debugfs_gitm_get,
		NULL,
		DEFINE_DEBUGFS_ATTRIBUTE(atk_debugfs_gitm, atk_debugfs_gitm_get, NULL,
		"0x%08llx\n");

		static int atk_acpi_print(char buf, size_t sz, union acpi_object obj)
		@@ -803,7 +801,7 @@ static void atk_debugfs_init(struct atk_data *data)
		if (!f \|\| IS_ERR(f))
		goto cleanup;

		f = debugfs_create_file("gitm", 0400, d, data,
		f = debugfs_create_file_unsafe("gitm", 0400, d, data,
		&atk_debugfs_gitm);
		if (!f \|\| IS_ERR(f))
		goto cleanup;

Admin message