Commit f9fa2b18 authored by Mark Brown's avatar Mark Brown
Browse files

ASoC: dapm: Sprinkle lockdep asserts through the code 



Try to spot locking issues by asserting that the DAPM mutex is held when
it should be. There's a bit of fun due to us not requiring the lock to be
held prior to the card being instantiated which mean we need to wrap the
assert in some paths and this isn't methodical by any stretch of the
imagination.

Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 492c0a18

sound/soc/soc-dapm.c

+18 −0
Original line number Diff line number Diff line
@@ -115,6 +115,12 @@ static int dapm_down_seq[] = { 
	[snd_soc_dapm_post] = 14,

};



static void dapm_assert_locked(struct snd_soc_dapm_context *dapm)

{

	if (dapm->card && dapm->card->instantiated)

		lockdep_assert_held(&dapm->card->dapm_mutex);

}



static void pop_wait(u32 pop_time)

{

	if (pop_time)
@@ -148,6 +154,8 @@ static bool dapm_dirty_widget(struct snd_soc_dapm_widget *w) 


static void dapm_mark_dirty(struct snd_soc_dapm_widget *w, const char *reason)

{

	dapm_assert_locked(w->dapm);



	if (!dapm_dirty_widget(w)) {

		dev_vdbg(w->dapm->dev, "Marking %s dirty due to %s\n",

			 w->name, reason);
@@ -360,6 +368,8 @@ static void dapm_reset(struct snd_soc_card *card) 
{

	struct snd_soc_dapm_widget *w;



	lockdep_assert_held(&card->dapm_mutex);



	memset(&card->dapm_stats, 0, sizeof(card->dapm_stats));



	list_for_each_entry(w, &card->widgets, list) {
@@ -1823,6 +1833,8 @@ static int dapm_power_widgets(struct snd_soc_card *card, int event) 
	ASYNC_DOMAIN_EXCLUSIVE(async_domain);

	enum snd_soc_bias_level bias;



	lockdep_assert_held(&card->dapm_mutex);



	trace_snd_soc_dapm_start(card);



	list_for_each_entry(d, &card->dapm_list, list) {
@@ -2118,6 +2130,8 @@ static int soc_dapm_mux_update_power(struct snd_soc_card *card, 
	struct snd_soc_dapm_path *path;

	int found = 0;



	lockdep_assert_held(&card->dapm_mutex);



	/* find dapm widget path assoc with kcontrol */

	dapm_kcontrol_for_each_path(path, kcontrol) {

		if (!path->name || !e->texts[mux])
@@ -2168,6 +2182,8 @@ static int soc_dapm_mixer_update_power(struct snd_soc_card *card, 
	struct snd_soc_dapm_path *path;

	int found = 0;



	lockdep_assert_held(&card->dapm_mutex);



	/* find dapm widget path assoc with kcontrol */

	dapm_kcontrol_for_each_path(path, kcontrol) {

		found = 1;
@@ -2333,6 +2349,8 @@ static int snd_soc_dapm_set_pin(struct snd_soc_dapm_context *dapm, 
{

	struct snd_soc_dapm_widget *w = dapm_find_widget(dapm, pin, true);



	dapm_assert_locked(dapm);



	if (!w) {

		dev_err(dapm->dev, "ASoC: DAPM unknown pin %s\n", pin);

		return -EINVAL;

CRA Git | Maintained and supported by SUSTech CRA and CCSE