Commit f9dfed1c authored Jun 09, 2019 by Finn Thain Committed by Martin K. Petersen Jun 20, 2019

scsi: NCR5380: Handle PDMA failure reliably

A PDMA error is handled in the core driver by setting the device's 'borken'
flag and aborting the command. Unfortunately, do_abort() is not
dependable. Perform a SCSI bus reset instead, to make sure that the command
fails and gets retried.

Cc: Michael Schmitz <schmitzmic@gmail.com>
Cc: stable@vger.kernel.org # v4.20+
Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Stan Johnson <userm57@yahoo.com>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 57f31326

drivers/scsi/NCR5380.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1761,10 +1761,8 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
		scmd_printk(KERN_INFO, cmd,
		"switching to slow handshake\n");
		cmd->device->borken = 1;
		sink = 1;
		do_abort(instance);
		cmd->result = DID_ERROR << 16;
		/* XXX - need to source or sink data here, as appropriate */
		do_reset(instance);
		bus_reset_cleanup(instance);
		}
		} else {
		/* Transfer a small chunk so that the

Admin message