Commit f9de6d74 authored by Mark Brown's avatar Mark Brown
Browse files

ASoC: Move bias level decision into main dapm_power_widgets() 



Future patches will try to reduce the number of widgets we check on each
DAPM run but we're still going to need to look and see if the devices is
on at all so we can manage the overall device bias. Move these checks out
into the main dapm_power_widgets() function so we don't have to think about
them for now.

Once we're doing more incremental updates it'll probably be worth using
refcounts for each bias level to avoid having to do the sweep over all
widgets but that's not going to be where the big performance wins are.

Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 05623c43

sound/soc/soc-dapm.c

+23 −21
Original line number Diff line number Diff line
@@ -1218,7 +1218,6 @@ static void dapm_power_one_widget(struct snd_soc_dapm_widget *w, 
				  struct list_head *up_list,

				  struct list_head *down_list)

{

	struct snd_soc_dapm_context *d;

	int power;



	switch (w->id) {
@@ -1238,26 +1237,6 @@ static void dapm_power_one_widget(struct snd_soc_dapm_widget *w, 
		else

			power = 1;



		if (power) {

			d = w->dapm;



			/* Supplies and micbiases only bring the

			 * context up to STANDBY as unless something

			 * else is active and passing audio they

			 * generally don't require full power.

			 */

			switch (w->id) {

			case snd_soc_dapm_supply:

			case snd_soc_dapm_micbias:

				if (d->target_bias_level < SND_SOC_BIAS_STANDBY)

					d->target_bias_level = SND_SOC_BIAS_STANDBY;

				break;

			default:

				d->target_bias_level = SND_SOC_BIAS_ON;

				break;

			}

		}



		dapm_widget_set_power(w, power, up_list, down_list);

		break;

	}
@@ -1302,6 +1281,29 @@ static int dapm_power_widgets(struct snd_soc_dapm_context *dapm, int event) 
		dapm_power_one_widget(w, &up_list, &down_list);

	}



	list_for_each_entry(w, &card->widgets, list) {

		if (w->power) {

			d = w->dapm;



			/* Supplies and micbiases only bring the

			 * context up to STANDBY as unless something

			 * else is active and passing audio they

			 * generally don't require full power.

			 */

			switch (w->id) {

			case snd_soc_dapm_supply:

			case snd_soc_dapm_micbias:

				if (d->target_bias_level < SND_SOC_BIAS_STANDBY)

					d->target_bias_level = SND_SOC_BIAS_STANDBY;

				break;

			default:

				d->target_bias_level = SND_SOC_BIAS_ON;

				break;

			}

		}



	}



	/* If there are no DAPM widgets then try to figure out power from the

	 * event type.

	 */

CRA Git | Maintained and supported by SUSTech CRA and CCSE