Commit f9d672f1 authored Jan 18, 2019 by Wei Yongjun Committed by Johannes Berg Jan 19, 2019

virt_wifi: fix error return code in virt_wifi_newlink()



Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: c7cdba31 ("mac80211-next: rtnetlink wifi simulation device")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent a0dc0203

drivers/net/wireless/virt_wifi.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -530,8 +530,10 @@ static int virt_wifi_newlink(struct net src_net, struct net_device dev,
		SET_NETDEV_DEV(dev, &priv->lowerdev->dev);
		dev->ieee80211_ptr = kzalloc(sizeof(*dev->ieee80211_ptr), GFP_KERNEL);

		if (!dev->ieee80211_ptr)
		if (!dev->ieee80211_ptr) {
		err = -ENOMEM;
		goto remove_handler;
		}

		dev->ieee80211_ptr->iftype = NL80211_IFTYPE_STATION;
		dev->ieee80211_ptr->wiphy = common_wiphy;

Admin message