Commit f9d106a6 authored Apr 23, 2007 by Herbert Xu Committed by David S. Miller Apr 25, 2007

[NET]: Warn about GSO/checksum abuse



Now that Patrick has added the code to deal with GSO in netfilter,
we no longer need the crutch that computes partial checksums just
before transmission.

This patch turns this into a warning again.  If this goes OK, we
can then turn it into a BUG_ON and remove the gso_send_check cruft.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7752237e

net/core/dev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1202,7 +1202,7 @@ struct sk_buff skb_gso_segment(struct sk_buff skb, int features)
		skb->mac_len = skb->network_header - skb->mac_header;
		__skb_pull(skb, skb->mac_len);

		if (unlikely(skb->ip_summed != CHECKSUM_PARTIAL)) {
		if (WARN_ON(skb->ip_summed != CHECKSUM_PARTIAL)) {
		if (skb_header_cloned(skb) &&
		(err = pskb_expand_head(skb, 0, 0, GFP_ATOMIC)))
		return ERR_PTR(err);

Admin message