Commit f9c78128 authored by Lars Ellenberg's avatar Lars Ellenberg Committed by Jens Axboe
Browse files

drbd: always implicitly close last epoch when idle 



Once our sender thread needs to wait_for_work(),
and actually needs to schedule(), just before we do that,
we already check if it is useful to implicitly close the last epoch.

The condition was too strict: only implicitly close the epoch,
if there have been no new (write) requests at all.

The assumption was that if there were new requests, they would
always be communicated one way or another, and would send necessary
epoch separating barriers explicitly.

This is not always true, e.g. when becoming diskless,
or while explicitly starting a full resync.

The last communicated epoch could stay open for a long time,
locking down corresponding activity log extents.

It is safe to always implicitly send that last barrier, as soon as we
determin that there cannot be more requests in the last communicated
epoch, even if there have been (uncommunicated) new requests in new
epochs meanwhile.

Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent e4d7d6f4

drivers/block/drbd/drbd_worker.c

+15 −33
Original line number Diff line number Diff line
@@ -1799,34 +1799,6 @@ void drbd_start_resync(struct drbd_device *device, enum drbd_conns side) 
	mutex_unlock(device->state_mutex);

}



/* If the resource already closed the current epoch, but we did not

 * (because we have not yet seen new requests), we should send the

 * corresponding barrier now.  Must be checked within the same spinlock

 * that is used to check for new requests. */

static bool need_to_send_barrier(struct drbd_connection *connection)

{

	if (!connection->send.seen_any_write_yet)

		return false;



	/* Skip barriers that do not contain any writes.

	 * This may happen during AHEAD mode. */

	if (!connection->send.current_epoch_writes)

		return false;



	/* ->req_lock is held when requests are queued on

	 * connection->sender_work, and put into ->transfer_log.

	 * It is also held when ->current_tle_nr is increased.

	 * So either there are already new requests queued,

	 * and corresponding barriers will be send there.

	 * Or nothing new is queued yet, so the difference will be 1.

	 */

	if (atomic_read(&connection->current_tle_nr) !=

	    connection->send.current_epoch_nr + 1)

		return false;



	return true;

}



static bool dequeue_work_batch(struct drbd_work_queue *queue, struct list_head *work_list)

{

	spin_lock_irq(&queue->q_lock);
@@ -1885,12 +1857,22 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head * 
			spin_unlock_irq(&connection->resource->req_lock);

			break;

		}

		send_barrier = need_to_send_barrier(connection);



		/* We found nothing new to do, no to-be-communicated request,

		 * no other work item.  We may still need to close the last

		 * epoch.  Next incoming request epoch will be connection ->

		 * current transfer log epoch number.  If that is different

		 * from the epoch of the last request we communicated, it is

		 * safe to send the epoch separating barrier now.

		 */

		send_barrier =

			atomic_read(&connection->current_tle_nr) !=

			connection->send.current_epoch_nr;

		spin_unlock_irq(&connection->resource->req_lock);

		if (send_barrier) {

			drbd_send_barrier(connection);

			connection->send.current_epoch_nr++;

		}



		if (send_barrier)

			maybe_send_barrier(connection,

					connection->send.current_epoch_nr + 1);

		schedule();

		/* may be woken up for other things but new work, too,

		 * e.g. if the current epoch got closed.

CRA Git | Maintained and supported by SUSTech CRA and CCSE