kconfig: qconf: create QApplication after option checks (f9a825a7) · Commits · 戴 / test

'scripts/kconfig/qconf -h' just calls usage() and exits, with QApplication unused. There is no need to construct QApplication so early. Do it after the parse stage. Signed-off-by:

Masahiro Yamada <masahiroy@kernel.org> Tested-by:

Randy Dunlap <rdunlap@infradead.org>

scripts/kconfig/qconf.cc

+2 −1

Original line number	Diff line number	Diff line
		@@ -1851,7 +1851,6 @@ int main(int ac, char** av)
		const char *name;

		progname = av[0];
		configApp = new QApplication(ac, av);
		if (ac > 1 && av[1][0] == '-') {
		switch (av[1][1]) {
		case 's':
		@@ -1872,6 +1871,8 @@ int main(int ac, char** av)
		conf_read(NULL);
		//zconfdump(stdout);

		configApp = new QApplication(ac, av);

		configSettings = new ConfigSettings();
		configSettings->beginGroup("/kconfig/qconf");
		v = new ConfigMainWindow();

Admin message