Commit f9a66600 authored by Paul Gortmaker's avatar Paul Gortmaker Committed by Bjorn Helgaas
Browse files

PCI: qcom: Make explicitly non-modular 



This code is not being built as a module by anyone:

  drivers/pci/host/Kconfig:config PCIE_QCOM
  drivers/pci/host/Kconfig:  bool "Qualcomm PCIe controller"

Remove uses of MODULE_DESCRIPTION(), MODULE_AUTHOR(), MODULE_LICENSE(),
etc., so that when reading the driver there is no doubt it is builtin-only.
The information is preserved in comments at the top of the file.

Note that for non-modular code, MODULE_DEVICE_TABLE is a no-op and
builtin_platform_driver() uses the same init level priority as
module_platform_driver(), so this doesn't change init ordering.

Explicitly disallow driver unbind, since that doesn't have a sensible use
case anyway, and it allows us to drop the ".remove" code for non-modular
drivers.

[bhelgaas: changelog]
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
CC: Stanimir Varbanov <svarbanov@mm-sol.com>
parent d29438d6

drivers/pci/host/pcie-qcom.c

+7 −21
Original line number Diff line number Diff line 
/*

 * Qualcomm PCIe root complex driver

 *

 * Copyright (c) 2014-2015, The Linux Foundation. All rights reserved.

 * Copyright 2015 Linaro Limited.

 *

 * Author: Stanimir Varbanov <svarbanov@mm-sol.com>

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and

 * only version 2 as published by the Free Software Foundation.
@@ -19,7 +23,7 @@ 
#include <linux/io.h>

#include <linux/iopoll.h>

#include <linux/kernel.h>

#include <linux/module.h>

#include <linux/init.h>

#include <linux/of_device.h>

#include <linux/of_gpio.h>

#include <linux/pci.h>
@@ -570,37 +574,19 @@ static int qcom_pcie_probe(struct platform_device *pdev) 
	return 0;

}



static int qcom_pcie_remove(struct platform_device *pdev)

{

	struct qcom_pcie *pcie = platform_get_drvdata(pdev);



	qcom_ep_reset_assert(pcie);

	phy_power_off(pcie->phy);

	phy_exit(pcie->phy);

	pcie->ops->deinit(pcie);



	return 0;

}



static const struct of_device_id qcom_pcie_match[] = {

	{ .compatible = "qcom,pcie-ipq8064", .data = &ops_v0 },

	{ .compatible = "qcom,pcie-apq8064", .data = &ops_v0 },

	{ .compatible = "qcom,pcie-apq8084", .data = &ops_v1 },

	{ }

};

MODULE_DEVICE_TABLE(of, qcom_pcie_match);



static struct platform_driver qcom_pcie_driver = {

	.probe = qcom_pcie_probe,

	.remove = qcom_pcie_remove,

	.driver = {

		.name = "qcom-pcie",

		.suppress_bind_attrs = true,

		.of_match_table = qcom_pcie_match,

	},

};



module_platform_driver(qcom_pcie_driver);



MODULE_AUTHOR("Stanimir Varbanov <svarbanov@mm-sol.com>");

MODULE_DESCRIPTION("Qualcomm PCIe root complex driver");

MODULE_LICENSE("GPL v2");
 
builtin_platform_driver(qcom_pcie_driver);

CRA Git | Maintained and supported by SUSTech CRA and CCSE