Commit f99a6abe authored by Sara Sharon's avatar Sara Sharon Committed by Luca Coelho
Browse files

iwlwifi: mvm: memset binding before setting values 



The changes in commit 9415af7f ("iwlwifi: mvm: support new binding
API") assigned values that were later memset to 0.  Move the memset
earlier.

Fixes: 9415af7f ("iwlwifi: mvm: support new binding API")
Signed-off-by: default avatarSara Sharon <sara.sharon@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent a1a57877

drivers/net/wireless/intel/iwlwifi/mvm/binding.c

+2 −2
Original line number Diff line number Diff line
@@ -86,6 +86,8 @@ static int iwl_mvm_binding_cmd(struct iwl_mvm *mvm, u32 action, 
	u32 status;

	int size;



	memset(&cmd, 0, sizeof(cmd));



	if (fw_has_capa(&mvm->fw->ucode_capa,

			IWL_UCODE_TLV_CAPA_BINDING_CDB_SUPPORT)) {

		size = sizeof(cmd);
@@ -98,8 +100,6 @@ static int iwl_mvm_binding_cmd(struct iwl_mvm *mvm, u32 action, 
		size = IWL_BINDING_CMD_SIZE_V1;

	}



	memset(&cmd, 0, sizeof(cmd));



	cmd.id_and_color = cpu_to_le32(FW_CMD_ID_AND_COLOR(phyctxt->id,

							   phyctxt->color));

	cmd.action = cpu_to_le32(action);

CRA Git | Maintained and supported by SUSTech CRA and CCSE