Commit f9981bc5 authored Jul 26, 2019 by Thomas Gleixner Committed by Herbert Xu Aug 02, 2019

crypto: api - Remove redundant #ifdef in crypto_yield()



While looking at CONFIG_PREEMPT dependencies treewide the #ifdef in
crypto_yield() matched.

CONFIG_PREEMPT and CONFIG_PREEMPT_VOLUNTARY are mutually exclusive so the
extra !CONFIG_PREEMPT conditional is redundant.

cond_resched() has only an effect when CONFIG_PREEMPT_VOLUNTARY is set,
otherwise it's a stub which the compiler optimizes out.

Remove the whole conditional.

No functional change.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-crypto@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 3e75241b

include/crypto/algapi.h

+0 −2

Original line number	Diff line number	Diff line
		@@ -409,10 +409,8 @@ static inline int crypto_memneq(const void a, const void b, size_t size)

		static inline void crypto_yield(u32 flags)
		{
		#if !defined(CONFIG_PREEMPT) \|\| defined(CONFIG_PREEMPT_VOLUNTARY)
		if (flags & CRYPTO_TFM_REQ_MAY_SLEEP)
		cond_resched();
		#endif
		}

		int crypto_register_notifier(struct notifier_block *nb);

Admin message