x86/resctrl: Use container_of() in delayed_work handlers (f995801b) · Commits · 戴 / test

mbm_handle_overflow() and cqm_handle_limbo() are both provided with the domain's work_struct when called, but use get_domain_from_cpu() to find the domain, along with the appropriate error handling. container_of() saves some list walking and bitmap testing, use that instead. Signed-off-by:

James Morse <james.morse@arm.com> Signed-off-by:

Borislav Petkov <bp@suse.de> Reviewed-by:

Reinette Chatre <reinette.chatre@intel.com> Link: https://lkml.kernel.org/r/20200708163929.2783-5-james.morse@arm.com

arch/x86/kernel/cpu/resctrl/monitor.c

+2 −11

Original line number	Diff line number	Diff line
		@@ -477,19 +477,13 @@ void cqm_handle_limbo(struct work_struct *work)
		mutex_lock(&rdtgroup_mutex);

		r = &rdt_resources_all[RDT_RESOURCE_L3];
		d = get_domain_from_cpu(cpu, r);

		if (!d) {
		pr_warn_once("Failure to get domain for limbo worker\n");
		goto out_unlock;
		}
		d = container_of(work, struct rdt_domain, cqm_limbo.work);

		__check_limbo(d, false);

		if (has_busy_rmid(r, d))
		schedule_delayed_work_on(cpu, &d->cqm_limbo, delay);

		out_unlock:
		mutex_unlock(&rdtgroup_mutex);
		}

		@@ -519,10 +513,7 @@ void mbm_handle_overflow(struct work_struct *work)
		goto out_unlock;

		r = &rdt_resources_all[RDT_RESOURCE_L3];

		d = get_domain_from_cpu(cpu, r);
		if (!d)
		goto out_unlock;
		d = container_of(work, struct rdt_domain, mbm_over.work);

		list_for_each_entry(prgrp, &rdt_all_groups, rdtgroup_list) {
		mbm_update(r, d, prgrp->mon.rmid);

Admin message