Commit f988f24e authored by Lv Zheng's avatar Lv Zheng Committed by Rafael J. Wysocki
Browse files

ACPICA: Debugger: Add thread ID support so that single step mode can only... 


ACPICA: Debugger: Add thread ID support so that single step mode can only apply to the debugger thread

When the debugger is running in the kernel mode, acpi_db_single_step() may
also be invoked by the kernel runtime code path but the single stepping
command prompt may be erronously logged as the kernel logs and runtime code
path cannot proceed.

This patch fixes this issue by adding acpi_gbl_db_thread_id for the debugger
thread and preventing acpi_db_single_step() to be invoked from other threads.

It is not suitable to add acpi_thread_id parameter for acpi_os_execute() as
the function may be implemented as work queue on some hosts. So it is
better to let the hosts invoke acpi_set_debugger_thread_id(). Currently
acpiexec is not configured as DEBUGGER_MULTI_THREADED, but we can do this.
When we do this, it is better to invoke acpi_set_debugger_thread_id() in
acpi_os_execute() when the execution type is OSL_DEBUGGER_MAIN_THREAD. The
support should look like:
  create_thread(&tid);
  if (type == OSL_DEBUGGER_MAIN_THREAD)
      acpi_set_debugger_thread_id(tid);
  resume_thread(tid);
Similarly, semop() may be used for pthread implementation. But this patch
simply skips debugger thread ID check for application instead of
introducing such complications as there is no need to skip
acpi_db_single_step() for an application debugger - acpiexec.

Note that the debugger thread ID can also be used by acpi_os_printf() to
filter out debugger output. Lv Zheng.

Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 086ab742

drivers/acpi/acpica/acglobal.h

+1 −0
Original line number Diff line number Diff line
@@ -327,6 +327,7 @@ ACPI_GLOBAL(struct acpi_external_file *, acpi_gbl_external_file_list); 


ACPI_INIT_GLOBAL(u8, acpi_gbl_abort_method, FALSE);

ACPI_INIT_GLOBAL(u8, acpi_gbl_method_executing, FALSE);

ACPI_INIT_GLOBAL(acpi_thread_id, acpi_gbl_db_thread_id, ACPI_INVALID_THREAD_ID);



ACPI_GLOBAL(u8, acpi_gbl_db_opt_no_ini_methods);

ACPI_GLOBAL(u8, acpi_gbl_db_opt_no_region_support);

drivers/acpi/acpica/aclocal.h

+8 −0
Original line number Diff line number Diff line
@@ -109,6 +109,14 @@ struct acpi_rw_lock { 


#define ACPI_MUTEX_NOT_ACQUIRED         (acpi_thread_id) 0



/* This Thread ID means an invalid thread ID */



#ifdef ACPI_OS_INVALID_THREAD_ID

#define ACPI_INVALID_THREAD_ID          ACPI_OS_INVALID_THREAD_ID

#else

#define ACPI_INVALID_THREAD_ID          ((acpi_thread_id) 0xFFFFFFFF)

#endif



/* Table for the global mutexes */



struct acpi_mutex_info {

drivers/acpi/acpica/dbexec.c

+2 −1
Original line number Diff line number Diff line
@@ -725,7 +725,8 @@ acpi_db_create_execution_threads(char *num_threads_arg, 


	for (i = 0; i < (num_threads); i++) {

		status =

		    acpi_os_execute(OSL_DEBUGGER_THREAD, acpi_db_method_thread,

		    acpi_os_execute(OSL_DEBUGGER_EXEC_THREAD,

				    acpi_db_method_thread,

				    &acpi_gbl_db_method_info);

		if (ACPI_FAILURE(status)) {

			break;

drivers/acpi/acpica/dbxface.c

+27 −1
Original line number Diff line number Diff line
@@ -164,6 +164,12 @@ acpi_db_single_step(struct acpi_walk_state * walk_state, 


	ACPI_FUNCTION_ENTRY();



#ifndef ACPI_APPLICATION

	if (acpi_gbl_db_thread_id != acpi_os_get_thread_id()) {

		return (AE_OK);

	}

#endif



	/* Check the abort flag */



	if (acpi_gbl_abort_method) {
@@ -431,7 +437,7 @@ acpi_status acpi_initialize_debugger(void) 
		/* Create the debug execution thread to execute commands */



		acpi_gbl_db_threads_terminated = FALSE;

		status = acpi_os_execute(OSL_DEBUGGER_THREAD,

		status = acpi_os_execute(OSL_DEBUGGER_MAIN_THREAD,

					 acpi_db_execute_thread, NULL);

		if (ACPI_FAILURE(status)) {

			ACPI_EXCEPTION((AE_INFO, status,
@@ -439,6 +445,8 @@ acpi_status acpi_initialize_debugger(void) 
			acpi_gbl_db_threads_terminated = TRUE;

			return_ACPI_STATUS(status);

		}

	} else {

		acpi_gbl_db_thread_id = acpi_os_get_thread_id();

	}



	return_ACPI_STATUS(AE_OK);
@@ -485,3 +493,21 @@ void acpi_terminate_debugger(void) 
}



ACPI_EXPORT_SYMBOL(acpi_terminate_debugger)



/*******************************************************************************

 *

 * FUNCTION:    acpi_set_debugger_thread_id

 *

 * PARAMETERS:  thread_id       - Debugger thread ID

 *

 * RETURN:      None

 *

 * DESCRIPTION: Set debugger thread ID

 *

 ******************************************************************************/

void acpi_set_debugger_thread_id(acpi_thread_id thread_id)

{

	acpi_gbl_db_thread_id = thread_id;

}



ACPI_EXPORT_SYMBOL(acpi_set_debugger_thread_id)

include/acpi/acpiosxf.h

+2 −1
Original line number Diff line number Diff line
@@ -55,7 +55,8 @@ typedef enum { 
	OSL_GLOBAL_LOCK_HANDLER,

	OSL_NOTIFY_HANDLER,

	OSL_GPE_HANDLER,

	OSL_DEBUGGER_THREAD,

	OSL_DEBUGGER_MAIN_THREAD,

	OSL_DEBUGGER_EXEC_THREAD,

	OSL_EC_POLL_HANDLER,

	OSL_EC_BURST_HANDLER

} acpi_execute_type;

CRA Git | Maintained and supported by SUSTech CRA and CCSE