Commit f986978b authored Sep 22, 2018 by Karthik Nishanth Committed by Greg Kroah-Hartman Sep 25, 2018

Staging: rtlwifi: remove unnecessary NULL check

The member regd of the struct rtl_priv is true in a boolean context.

drivers/staging/rtlwifi/regd.c:413:27: warning: address of 'rtlpriv->regd' will always
      evaluate to 'true' [-Wpointer-bool-conversion]
        if (!wiphy || !&rtlpriv->regd)
                      ~ ~~~~~~~~~^~~~
1 warning generated.

Link: https://github.com/ClangBuiltLinux/linux/issues/170



Signed-off-by: Karthik Nishanth <nishanthkarthik@live.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f007d901

drivers/staging/rtlwifi/regd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -410,7 +410,7 @@ int rtl_regd_init(struct ieee80211_hw *hw,
		struct wiphy *wiphy = hw->wiphy;
		struct country_code_to_enum_rd *country = NULL;

		if (!wiphy \|\| !&rtlpriv->regd)
		if (!wiphy)
		return -EINVAL;

		/* init country_code from efuse channel plan */

Admin message