Commit f9837107 authored Apr 14, 2010 by Dave Chinner Committed by Alex Elder May 19, 2010

xfs: make the log ticket transaction id random



The transaction ID that is written to the log for a transaction is
currently set by taking the lower 32 bits of the memory address of
the ticket structure.  This is not guaranteed to be unique as
tickets comes from a slab and slots can be reallocated immediately
after being freed. As a result, there is no guarantee of uniqueness
in the ticket ID value.

Fix this by assigning a random number to the ticket ID field so that
it is extremely unlikely that duplicates will occur and remove the
possibility of transactions being mixed up during recovery due to
duplicate IDs.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

parent 36adecff

fs/xfs/xfs_log.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3417,7 +3417,7 @@ xlog_ticket_alloc(
		tic->t_curr_res = unit_bytes;
		tic->t_cnt = cnt;
		tic->t_ocnt = cnt;
		tic->t_tid = (xlog_tid_t)((__psint_t)tic & 0xffffffff);
		tic->t_tid = random32();
		tic->t_clientid = client;
		tic->t_flags = XLOG_TIC_INITED;
		tic->t_trans_type = 0;

Admin message