Commit f96e8717 authored May 06, 2020 by Taehee Yoo Committed by David S. Miller May 07, 2020

hsr: remove WARN_ONCE() in hsr_fill_frame_info()



When VLAN frame is being sent, hsr calls WARN_ONCE() because hsr doesn't
support VLAN. But using WARN_ONCE() is overdoing.
Using netdev_warn_once() is enough.

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7596ac9d

net/hsr/hsr_forward.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -321,7 +321,7 @@ static int hsr_fill_frame_info(struct hsr_frame_info *frame,
		if (ethhdr->h_proto == htons(ETH_P_8021Q)) {
		frame->is_vlan = true;
		/* FIXME: */
		WARN_ONCE(1, "HSR: VLAN not yet supported");
		netdev_warn_once(skb->dev, "VLAN not yet supported");
		}
		if (ethhdr->h_proto == htons(ETH_P_PRP) \|\|
		ethhdr->h_proto == htons(ETH_P_HSR)) {

Admin message