Commit f960727e authored Jun 13, 2012 by Vishal Agarwal Committed by Gustavo Padovan Jun 14, 2012

Bluetooth: Fix sending HCI_Disconnect only when connected



HCI_Disconnect should only be sent after connection is established.
If connection is not yet established and HCI_Disconnect is called
then disconnection complete will be received with a handle which
does not exist and hence this event will be ignored.
But as mgmt.c will not receive this event, its variable for pending
command is not cleared.This will result in future Disconnect commands
for that BD Address to be blocked with error busy.

Signed-off-by: Vishal Agarwal <vishal.agarwal@stericsson.com>
Acked-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

parent 6c4ae5c2

net/bluetooth/mgmt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1598,7 +1598,7 @@ static int disconnect(struct sock sk, struct hci_dev hdev, void *data,
		else
		conn = hci_conn_hash_lookup_ba(hdev, LE_LINK, &cp->addr.bdaddr);

		if (!conn) {
		if (!conn \|\| conn->state == BT_OPEN \|\| conn->state == BT_CLOSED) {
		err = cmd_status(sk, hdev->id, MGMT_OP_DISCONNECT,
		MGMT_STATUS_NOT_CONNECTED);
		goto failed;

Admin message