Commit f95ebdbe authored Jul 21, 2020 by Josef Bacik Committed by David Sterba Jul 27, 2020

btrfs: don't WARN if we abort a transaction with EROFS



If we got some sort of corruption via a read and call
btrfs_handle_fs_error() we'll set BTRFS_FS_STATE_ERROR on the fs and
complain.  If a subsequent trans handle trips over this it'll get EROFS
and then abort.  However at that point we're not aborting for the
original reason, we're aborting because we've been flipped read only.
We do not need to WARN_ON() here.

CC: stable@vger.kernel.org # 5.4+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 3ebac17c

fs/btrfs/ctree.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -3279,7 +3279,7 @@ do { \
		/* Report first abort since mount */ \
		if (!test_and_set_bit(BTRFS_FS_STATE_TRANS_ABORTED, \
		&((trans)->fs_info->fs_state))) { \
		if ((errno) != -EIO) { \
		if ((errno) != -EIO && (errno) != -EROFS) { \
		WARN(1, KERN_DEBUG \
		"BTRFS: Transaction aborted (error %d)\n", \
		(errno)); \

Admin message