Commit f958bd23 authored Dec 09, 2019 by Sean Christopherson Committed by Paolo Bonzini Jan 08, 2020

KVM: x86: Fix potential put_fpu() w/o load_fpu() on MPX platform



Unlike most state managed by XSAVE, MPX is initialized to zero on INIT.
Because INITs are usually recognized in the context of a VCPU_RUN call,
kvm_vcpu_reset() puts the guest's FPU so that the FPU state is resident
in memory, zeros the MPX state, and reloads FPU state to hardware.  But,
in the unlikely event that an INIT is recognized during
kvm_arch_vcpu_ioctl_get_mpstate() via kvm_apic_accept_events(),
kvm_vcpu_reset() will call kvm_put_guest_fpu() without a preceding
kvm_load_guest_fpu() and corrupt the guest's FPU state (and possibly
userspace's FPU state as well).

Given that MPX is being removed from the kernel[*], fix the bug with the
simple-but-ugly approach of loading the guest's FPU during
KVM_GET_MP_STATE.

[*] See commit f240652b ("x86/mpx: Remove MPX APIs").

Fixes: f775b13e ("x86,kvm: move qemu/guest FPU switching out to vcpu_run")
Cc: stable@vger.kernel.org
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent bbfdafa8

arch/x86/kvm/x86.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -8714,6 +8714,8 @@ int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
		struct kvm_mp_state *mp_state)
		{
		vcpu_load(vcpu);
		if (kvm_mpx_supported())
		kvm_load_guest_fpu(vcpu);

		kvm_apic_accept_events(vcpu);
		if (vcpu->arch.mp_state == KVM_MP_STATE_HALTED &&
		@@ -8722,6 +8724,8 @@ int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
		else
		mp_state->mp_state = vcpu->arch.mp_state;

		if (kvm_mpx_supported())
		kvm_put_guest_fpu(vcpu);
		vcpu_put(vcpu);
		return 0;
		}

Admin message