Commit f9483392 authored by Andi Kleen's avatar Andi Kleen Committed by Arnaldo Carvalho de Melo
Browse files

perf stat: Add support for metrics in interval mode 



Now that we can modify the metrics printout functions easily, it's
straight forward to support metric printing for interval mode.  All that
is needed is to print the time stamp on every new line.  Pass the prefix
into the context and print it out.

v2: Move wrong hunk to here.

Committer note:

Before:

  [root@jouet ~]# perf stat -I 1000 -e instructions,cycles sleep 1
  #           time    counts unit events
       1.000168216   538,913      instructions
       1.000168216   748,765      cycles
       1.000660048   153,741      instructions
       1.000660048   214,066      cycles

After:

  # perf stat -I 1000 -e instructions,cycles sleep 1
  #           time    counts unit events
       1.000215928   519,620      instructions              #    0.69  insn per cycle
       1.000215928   752,003      cycles
       1.000946033   148,502      instructions              #    0.33  insn per cycle
       1.000946033   160,104      cycles

Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1454173616-17710-3-git-send-email-andi@firstfloor.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 140aeadc

tools/perf/builtin-stat.c

+13 −7
Original line number Original line Diff line number Diff line
@@ -738,6 +738,7 @@ static void aggr_printout(struct perf_evsel *evsel, int id, int nr) 
struct outstate {

struct outstate {

	FILE *fh;

	FILE *fh;

	bool newline;

	bool newline;

	const char *prefix;

};

};





#define METRIC_LEN  35

#define METRIC_LEN  35
@@ -752,6 +753,7 @@ static void new_line_std(void *ctx) 
static void do_new_line_std(struct outstate *os)

static void do_new_line_std(struct outstate *os)

{

{

	fputc('\n', os->fh);

	fputc('\n', os->fh);

	fputs(os->prefix, os->fh);

	if (stat_config.aggr_mode == AGGR_NONE)

	if (stat_config.aggr_mode == AGGR_NONE)

		fprintf(os->fh, "        ");

		fprintf(os->fh, "        ");

	if (stat_config.aggr_mode == AGGR_CORE)

	if (stat_config.aggr_mode == AGGR_CORE)
@@ -845,10 +847,14 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg) 
		fprintf(output, "%s%s", csv_sep, evsel->cgrp->name);

		fprintf(output, "%s%s", csv_sep, evsel->cgrp->name);

}

}





static void printout(int id, int nr, struct perf_evsel *counter, double uval)

static void printout(int id, int nr, struct perf_evsel *counter, double uval,

		     char *prefix)

{

{

	struct outstate os = { .fh = stat_config.output };

	struct perf_stat_output_ctx out;

	struct perf_stat_output_ctx out;

	struct outstate os = {

		.fh = stat_config.output,

		.prefix = prefix ? prefix : ""

	};

	print_metric_t pm = print_metric_std;

	print_metric_t pm = print_metric_std;

	void (*nl)(void *);

	void (*nl)(void *);
@@ -863,7 +869,7 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval) 
	out.new_line = nl;

	out.new_line = nl;

	out.ctx = &os;

	out.ctx = &os;





	if (!csv_output && !stat_config.interval)

	if (!csv_output)

		perf_stat__print_shadow_stats(counter, uval,

		perf_stat__print_shadow_stats(counter, uval,

				stat_config.aggr_mode == AGGR_GLOBAL ? 0 :

				stat_config.aggr_mode == AGGR_GLOBAL ? 0 :

				cpu_map__id_to_cpu(id),

				cpu_map__id_to_cpu(id),
@@ -923,7 +929,7 @@ static void print_aggr(char *prefix) 
				continue;

				continue;

			}

			}

			uval = val * counter->scale;

			uval = val * counter->scale;

			printout(id, nr, counter, uval);

			printout(id, nr, counter, uval, prefix);

			if (!csv_output)

			if (!csv_output)

				print_noise(counter, 1.0);

				print_noise(counter, 1.0);
@@ -954,7 +960,7 @@ static void print_aggr_thread(struct perf_evsel *counter, char *prefix) 
			fprintf(output, "%s", prefix);

			fprintf(output, "%s", prefix);





		uval = val * counter->scale;

		uval = val * counter->scale;

		printout(thread, 0, counter, uval);

		printout(thread, 0, counter, uval, prefix);





		if (!csv_output)

		if (!csv_output)

			print_noise(counter, 1.0);

			print_noise(counter, 1.0);
@@ -1004,7 +1010,7 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix) 
	}

	}





	uval = avg * counter->scale;

	uval = avg * counter->scale;

	printout(-1, 0, counter, uval);

	printout(-1, 0, counter, uval, prefix);





	print_noise(counter, avg);

	print_noise(counter, avg);
@@ -1057,7 +1063,7 @@ static void print_counter(struct perf_evsel *counter, char *prefix) 
		}

		}





		uval = val * counter->scale;

		uval = val * counter->scale;

		printout(cpu, 0, counter, uval);

		printout(cpu, 0, counter, uval, prefix);

		if (!csv_output)

		if (!csv_output)

			print_noise(counter, 1.0);

			print_noise(counter, 1.0);

		print_running(run, ena);

		print_running(run, ena);

CRA Git | Maintained and supported by SUSTech CRA and CCSE