Commit f94277af authored Sep 14, 2016 by Robin Murphy Committed by Rob Herring Sep 15, 2016

of/platform: Initialise dev->fwnode appropriately



Whilst we're some of the way towards a universal firmware property
interface, drivers which deal with both OF and ACPI probing end up
having to do things like this:

    dev->of_node ? &dev->of_node->fwnode : dev->fwnode

This seems unnecessary, when the OF code could instead simply fill in
the device's fwnode when binding the of_node, and let the drivers use
dev->fwnode either way. Let's give it a go and see what falls out.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>

parent a67e9472

drivers/of/platform.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -142,6 +142,7 @@ struct platform_device of_device_alloc(struct device_node np,
		}

		dev->dev.of_node = of_node_get(np);
		dev->dev.fwnode = &np->fwnode;
		dev->dev.parent = parent ? : &platform_bus;

		if (bus_id)
		@@ -241,6 +242,7 @@ static struct amba_device of_amba_device_create(struct device_node node,

		/* setup generic device info */
		dev->dev.of_node = of_node_get(node);
		dev->dev.fwnode = &node->fwnode;
		dev->dev.parent = parent ? : &platform_bus;
		dev->dev.platform_data = platform_data;
		if (bus_id)

Admin message