Commit f93bd17b authored Dec 14, 2016 by Paul Blakey Committed by David S. Miller Dec 17, 2016

net/sched: cls_flower: Use masked key when calling HW offloads



Zero bits on the mask signify a "don't care" on the corresponding bits
in key. Some HWs require those bits on the key to be zero. Since these
bits are masked anyway, it's okay to provide the masked key to all
drivers.

Fixes: 5b33f488 ('net/flower: Introduce hardware offload support')
Signed-off-by: Paul Blakey <paulb@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 970bfcd0

net/sched/cls_flower.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -252,7 +252,7 @@ static int fl_hw_replace_filter(struct tcf_proto *tp,
		offload.cookie = (unsigned long)f;
		offload.dissector = dissector;
		offload.mask = mask;
		offload.key = &f->key;
		offload.key = &f->mkey;
		offload.exts = &f->exts;

		tc->type = TC_SETUP_CLSFLOWER;

Admin message