Commit f9317ae5 authored Sep 22, 2020 by Hauke Mehrtens Committed by David S. Miller Sep 23, 2020

net: lantiq: Add locking for TX DMA channel



The TX DMA channel data is accessed by the xrx200_start_xmit() and the
xrx200_tx_housekeeping() function from different threads. Make sure the
accesses are synchronized by acquiring the netif_tx_lock() in the
xrx200_tx_housekeeping() function too. This lock is acquired by the
kernel before calling xrx200_start_xmit().

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ea6754ae

drivers/net/ethernet/lantiq_xrx200.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -245,6 +245,7 @@ static int xrx200_tx_housekeeping(struct napi_struct *napi, int budget)
		int pkts = 0;
		int bytes = 0;

		netif_tx_lock(net_dev);
		while (pkts < budget) {
		struct ltq_dma_desc *desc = &ch->dma.desc_base[ch->tx_free];

		@@ -268,6 +269,7 @@ static int xrx200_tx_housekeeping(struct napi_struct *napi, int budget)
		net_dev->stats.tx_bytes += bytes;
		netdev_completed_queue(ch->priv->net_dev, pkts, bytes);

		netif_tx_unlock(net_dev);
		if (netif_queue_stopped(net_dev))
		netif_wake_queue(net_dev);

Admin message