Commit f91d1b63 authored Jul 01, 2013 by Alexandre Belloni Committed by Jonathan Cameron Jul 03, 2013

iio: inkern: fix iio_convert_raw_to_processed_unlocked



When reading IIO_CHAN_INFO_OFFSET, the return value of iio_channel_read() for
success will be IIO_VAL*, checking for 0 is not correct.

Without this fix the offset applied by iio drivers will be ignored when
converting a raw value to one in appropriate base units (e.g mV) in
a IIO client drivers that use iio_convert_raw_to_processed including
iio-hwmon.

Cc: <stable@vger.kernel.org> # 3.10.x
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent 1c297a66

drivers/iio/inkern.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -451,7 +451,7 @@ static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan,
		int ret;

		ret = iio_channel_read(chan, &offset, NULL, IIO_CHAN_INFO_OFFSET);
		if (ret == 0)
		if (ret >= 0)
		raw64 += offset;

		scale_type = iio_channel_read(chan, &scale_val, &scale_val2,

Admin message