Commit f90fafec authored Jul 07, 2020 by Tiezhu Yang Committed by Marc Zyngier Jul 17, 2020

irqchip/loongson-htpic: Remove redundant kfree operation

In the function htpic_of_init(), when kzalloc htpic fails, it should
return -ENOMEM directly, no need to execute "goto" to kfree.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1594087972-21715-2-git-send-email-yangtiezhu@loongson.cn

parent 52b350cb

drivers/irqchip/irq-loongson-htpic.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -93,10 +93,8 @@ int __init htpic_of_init(struct device_node node, struct device_node parent)
		}

		htpic = kzalloc(sizeof(*htpic), GFP_KERNEL);
		if (!htpic) {
		err = -ENOMEM;
		goto out_free;
		}
		if (!htpic)
		return -ENOMEM;

		htpic->base = of_iomap(node, 0);
		if (!htpic->base) {