Commit f8fb4c38 authored by Lv Zheng's avatar Lv Zheng Committed by Rafael J. Wysocki
Browse files

ACPICA: Debugger: Split debugger initialization/termination APIs 

ACPICA commit 7a3f22baab000b186779dac64ad71d9776b8f432

It is likely that the debugger is enabled only when a userspace program
explicitly tells a kernel to do so, so it shouldn't be initialized as
early as current implementation.

The only tool requiring ACPI_DEBUGGER is acpiexec, so acpiexec need to call
the new APIs by itself. And BSD developers may also get notified to invoke
the APIs for DDB enabling. Lv Zheng.

This patch doesn't affect Linux kernel as debugger is currently not enabled
in the Linux kernel.

Link: https://github.com/acpica/acpica/commit/7a3f22ba


Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent cff94061

drivers/acpi/acpica/acdebug.h

+0 −4
Original line number Diff line number Diff line
@@ -77,10 +77,6 @@ struct acpi_db_execute_walk { 
/*

 * dbxface - external debugger interfaces

 */

acpi_status acpi_db_initialize(void);



void acpi_db_terminate(void);



acpi_status

acpi_db_single_step(struct acpi_walk_state *walk_state,

		    union acpi_parse_object *op, u32 op_type);

drivers/acpi/acpica/utxface.c

+0 −7
Original line number Diff line number Diff line
@@ -92,13 +92,6 @@ acpi_status __init acpi_terminate(void) 


	acpi_ut_mutex_terminate();



#ifdef ACPI_DEBUGGER



	/* Shut down the debugger */



	acpi_db_terminate();

#endif



	/* Now we can shutdown the OS-dependent layer */



	status = acpi_os_terminate();

drivers/acpi/acpica/utxfinit.c

+0 −11
Original line number Diff line number Diff line
@@ -124,17 +124,6 @@ acpi_status __init acpi_initialize_subsystem(void) 
		return_ACPI_STATUS(status);

	}



	/* If configured, initialize the AML debugger */



#ifdef ACPI_DEBUGGER

	status = acpi_db_initialize();

	if (ACPI_FAILURE(status)) {

		ACPI_EXCEPTION((AE_INFO, status,

				"During Debugger initialization"));

		return_ACPI_STATUS(status);

	}

#endif



	return_ACPI_STATUS(AE_OK);

}

include/acpi/acpixf.h

+3 −0
Original line number Diff line number Diff line
@@ -917,6 +917,9 @@ ACPI_DBG_DEPENDENT_RETURN_VOID(void 
ACPI_APP_DEPENDENT_RETURN_VOID(ACPI_PRINTF_LIKE(1)

				void ACPI_INTERNAL_VAR_XFACE

				acpi_log_error(const char *format, ...))

 acpi_status acpi_initialize_debugger(void);



void acpi_terminate_debugger(void);



/*

 * Divergences

CRA Git | Maintained and supported by SUSTech CRA and CCSE