Commit f8ed34ac authored by Jyri Sarha's avatar Jyri Sarha Committed by Tomi Valkeinen
Browse files

drm: drm_helper_crtc_enable_color_mgmt() => drm_crtc_enable_color_mgmt() 



Add drm_crtc_enable_color_mgmt(), remove drm_helper_crtc_enable_color_mgmt()
and update drm/i915-driver (the only user of the old function).

The new function is more flexible. It allows driver to enable only the
features it has without forcing to enable all three color management
properties: degamma lut, csc matrix (ctm), and gamma lut.

Suggested-by: default avatarDaniel Vetter <daniel@ffwll.ch>
Signed-off-by: default avatarJyri Sarha <jsarha@ti.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent a1dec226

drivers/gpu/drm/drm_crtc.c

+45 −0
Original line number Diff line number Diff line
@@ -6064,3 +6064,48 @@ struct drm_tile_group *drm_mode_create_tile_group(struct drm_device *dev, 
	return tg;

}

EXPORT_SYMBOL(drm_mode_create_tile_group);



/**

 * drm_crtc_enable_color_mgmt - enable color management properties

 * @crtc: DRM CRTC

 * @degamma_lut_size: the size of the degamma lut (before CSC)

 * @has_ctm: whether to attach ctm_property for CSC matrix

 * @gamma_lut_size: the size of the gamma lut (after CSC)

 *

 * This function lets the driver enable the color correction

 * properties on a CRTC. This includes 3 degamma, csc and gamma

 * properties that userspace can set and 2 size properties to inform

 * the userspace of the lut sizes. Each of the properties are

 * optional. The gamma and degamma properties are only attached if

 * their size is not 0 and ctm_property is only attached if has_ctm is

 * true.

 */

void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc,

				uint degamma_lut_size,

				bool has_ctm,

				uint gamma_lut_size)

{

	struct drm_device *dev = crtc->dev;

	struct drm_mode_config *config = &dev->mode_config;



	if (degamma_lut_size) {

		drm_object_attach_property(&crtc->base,

					   config->degamma_lut_property, 0);

		drm_object_attach_property(&crtc->base,

					   config->degamma_lut_size_property,

					   degamma_lut_size);

	}



	if (has_ctm)

		drm_object_attach_property(&crtc->base,

					   config->ctm_property, 0);



	if (gamma_lut_size) {

		drm_object_attach_property(&crtc->base,

					   config->gamma_lut_property, 0);

		drm_object_attach_property(&crtc->base,

					   config->gamma_lut_size_property,

					   gamma_lut_size);

	}

}

EXPORT_SYMBOL(drm_crtc_enable_color_mgmt);

drivers/gpu/drm/drm_crtc_helper.c

+0 −33
Original line number Diff line number Diff line
@@ -1121,36 +1121,3 @@ int drm_helper_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y, 
	return drm_plane_helper_commit(plane, plane_state, old_fb);

}

EXPORT_SYMBOL(drm_helper_crtc_mode_set_base);
 


/**

 * drm_helper_crtc_enable_color_mgmt - enable color management properties

 * @crtc: DRM CRTC

 * @degamma_lut_size: the size of the degamma lut (before CSC)

 * @gamma_lut_size: the size of the gamma lut (after CSC)

 *

 * This function lets the driver enable the color correction properties on a

 * CRTC. This includes 3 degamma, csc and gamma properties that userspace can

 * set and 2 size properties to inform the userspace of the lut sizes.

 */

void drm_helper_crtc_enable_color_mgmt(struct drm_crtc *crtc,

				       int degamma_lut_size,

				       int gamma_lut_size)

{

	struct drm_device *dev = crtc->dev;

	struct drm_mode_config *config = &dev->mode_config;



	drm_object_attach_property(&crtc->base,

				   config->degamma_lut_property, 0);

	drm_object_attach_property(&crtc->base,

				   config->ctm_property, 0);

	drm_object_attach_property(&crtc->base,

				   config->gamma_lut_property, 0);



	drm_object_attach_property(&crtc->base,

				   config->degamma_lut_size_property,

				   degamma_lut_size);

	drm_object_attach_property(&crtc->base,

				   config->gamma_lut_size_property,

				   gamma_lut_size);

}

EXPORT_SYMBOL(drm_helper_crtc_enable_color_mgmt);

drivers/gpu/drm/i915/intel_color.c

+2 −1
Original line number Diff line number Diff line
@@ -547,7 +547,8 @@ void intel_color_init(struct drm_crtc *crtc) 
	/* Enable color management support when we have degamma & gamma LUTs. */

	if (INTEL_INFO(dev)->color.degamma_lut_size != 0 &&

	    INTEL_INFO(dev)->color.gamma_lut_size != 0)

		drm_helper_crtc_enable_color_mgmt(crtc,

		drm_crtc_enable_color_mgmt(crtc,

					INTEL_INFO(dev)->color.degamma_lut_size,

					true,

					INTEL_INFO(dev)->color.gamma_lut_size);

}

include/drm/drm_crtc.h

+4 −1
Original line number Diff line number Diff line
@@ -2553,7 +2553,10 @@ extern struct drm_property *drm_mode_create_rotation_property(struct drm_device 
							      unsigned int supported_rotations);

extern unsigned int drm_rotation_simplify(unsigned int rotation,

					  unsigned int supported_rotations);



extern void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc,

				       uint degamma_lut_size,

				       bool has_ctm,

				       uint gamma_lut_size);

/* Helpers */



static inline struct drm_plane *drm_plane_find(struct drm_device *dev,

include/drm/drm_crtc_helper.h

+0 −3
Original line number Diff line number Diff line
@@ -48,9 +48,6 @@ extern bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, 
				     struct drm_display_mode *mode,

				     int x, int y,

				     struct drm_framebuffer *old_fb);

extern void drm_helper_crtc_enable_color_mgmt(struct drm_crtc *crtc,

					      int degamma_lut_size,

					      int gamma_lut_size);

extern bool drm_helper_crtc_in_use(struct drm_crtc *crtc);

extern bool drm_helper_encoder_in_use(struct drm_encoder *encoder);

CRA Git | Maintained and supported by SUSTech CRA and CCSE