Commit f8e8dcaf authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: mos7840: drop read-urb check 



Drop read-urb check which is always false from completion the callback.

The driver read-urb pointer is set at every open and is never cleared.

Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 7b2faede

drivers/usb/serial/mos7840.c

+0 −11
Original line number Original line Diff line number Diff line
@@ -457,12 +457,6 @@ static void mos7840_bulk_in_callback(struct urb *urb) 
		dev_dbg(&port->dev, "icount.rx is %d:\n", port->icount.rx);

		dev_dbg(&port->dev, "icount.rx is %d:\n", port->icount.rx);

	}

	}





	if (!mos7840_port->read_urb) {

		dev_dbg(&port->dev, "%s", "URB KILLED !!!\n");

		mos7840_port->read_urb_busy = false;

		return;

	}



	if (mos7840_port->has_led)

	if (mos7840_port->has_led)

		mos7840_led_activity(port);

		mos7840_led_activity(port);
@@ -1377,11 +1371,6 @@ static void mos7840_set_termios(struct tty_struct *tty, 




	mos7840_change_port_settings(tty, mos7840_port, old_termios);

	mos7840_change_port_settings(tty, mos7840_port, old_termios);





	if (!mos7840_port->read_urb) {

		dev_dbg(&port->dev, "%s", "URB KILLED !!!!!\n");

		return;

	}



	if (!mos7840_port->read_urb_busy) {

	if (!mos7840_port->read_urb_busy) {

		mos7840_port->read_urb_busy = true;

		mos7840_port->read_urb_busy = true;

		status = usb_submit_urb(mos7840_port->read_urb, GFP_KERNEL);

		status = usb_submit_urb(mos7840_port->read_urb, GFP_KERNEL);

CRA Git | Maintained and supported by SUSTech CRA and CCSE