Commit f8bb820d authored Apr 16, 2015 by Robin Gong Committed by Mark Brown Apr 16, 2015

spi: check tx_buf and rx_buf in spi_unmap_msg



Some spi device drivers use the same tx_buf and rx_buf repeatly for better
performance such as driver/input/touchsreen/ads7846.c, but spi core grab tx_buf
/rx_buf of transfer and set them as dummy_tx/dummy_rx once they are NULL. Thus,
in the second time the tx_buf/rx_buf will be replaced by dummy_tx/dummy_rx and
the data which produced by the last tx or rx may be wrongly sent to the device
or handled by the upper level protocol. This patch just keep the orignal value
of tx_buf/rx_buf if they are NULL after this transfer processed.

Signed-off-by: Robin Gong <b38343@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 56afdb70

drivers/spi/spi.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -583,6 +583,15 @@ static int spi_unmap_msg(struct spi_master master, struct spi_message msg)
		rx_dev = master->dma_rx->device->dev;

		list_for_each_entry(xfer, &msg->transfers, transfer_list) {
		/*
		* Restore the original value of tx_buf or rx_buf if they are
		* NULL.
		*/
		if (xfer->tx_buf == master->dummy_tx)
		xfer->tx_buf = NULL;
		if (xfer->rx_buf == master->dummy_rx)
		xfer->rx_buf = NULL;

		if (!master->can_dma(master, msg->spi, xfer))
		continue;

Admin message