Commit f895c53f authored Feb 01, 2010 by Chuck Lever Committed by Trond Myklebust Feb 10, 2010

NFS: Make close(2) asynchronous when closing NFS O_DIRECT files



For NFSv2 and v3:

O_DIRECT writes are always synchronous, and aren't cached, so nothing
should be flushed when closing an NFS O_DIRECT file descriptor.  Thus
there are no write errors to report on close(2).

In addition, there's no cached data to verify on the next open(2),
so we don't need clean GETATTR results at close time to compare with.

Thus, there's no need for the nfs_revalidate_inode() call when closing
an NFS O_DIRECT file.  This reduces the number of synchronous
on-the-wire requests for a simple open-write-close of an NFS O_DIRECT
file by roughly 20%.

For NFSv4:

Call nfs4_do_close() with wait set to zero when closing an NFS
O_DIRECT file.  The CLOSE will go on the wire, but the application
won't wait for it to complete.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent 7e381172

fs/nfs/inode.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -620,11 +620,6 @@ void put_nfs_open_context(struct nfs_open_context *ctx)
		__put_nfs_open_context(ctx, 0);
		}

		static void put_nfs_open_context_sync(struct nfs_open_context *ctx)
		{
		__put_nfs_open_context(ctx, 1);
		}

		/*
		* Ensure that mmap has a recent RPC credential for use when writing out
		* shared pages
		@@ -671,7 +666,7 @@ static void nfs_file_clear_open_context(struct file *filp)
		spin_lock(&inode->i_lock);
		list_move_tail(&ctx->list, &NFS_I(inode)->open_files);
		spin_unlock(&inode->i_lock);
		put_nfs_open_context_sync(ctx);
		__put_nfs_open_context(ctx, filp->f_flags & O_DIRECT ? 0 : 1);
		}
		}

Admin message