Commit f8878fad authored by Wolfram Sang's avatar Wolfram Sang
Browse files

i2c: aspeed: use proper annotation for "fall through" 



Use a better annotation, so GCC won't complain anymore:

drivers/i2c/busses/i2c-aspeed.c:458:15: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Tested-by: default avatarJae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: default avatarBrendan Higgins <brendanhiggins@google.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 2be6b472

drivers/i2c/busses/i2c-aspeed.c

+2 −2
Original line number Diff line number Diff line
@@ -456,7 +456,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status) 
			goto error_and_stop;

		}

		irq_handled |= ASPEED_I2CD_INTR_TX_ACK;

		/* fallthrough intended */

		/* fall through */

	case ASPEED_I2C_MASTER_TX_FIRST:

		if (bus->buf_index < msg->len) {

			bus->master_state = ASPEED_I2C_MASTER_TX;
@@ -472,7 +472,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status) 
		/* RX may not have completed yet (only address cycle) */

		if (!(irq_status & ASPEED_I2CD_INTR_RX_DONE))

			goto out_no_complete;

		/* fallthrough intended */

		/* fall through */

	case ASPEED_I2C_MASTER_RX:

		if (unlikely(!(irq_status & ASPEED_I2CD_INTR_RX_DONE))) {

			dev_err(bus->dev, "master failed to RX\n");

CRA Git | Maintained and supported by SUSTech CRA and CCSE