arm64: Fix show_unhandled_signal_ratelimited usage (f871d268) · Commits · 戴 / test

Commit introduced ratelimited usage for 'unhandled_signal' messages. The commit checks the ratelimit irrespective of whether the signal is handled or not, which is wrong and leads to false reports like the below in dmesg : __do_user_fault: 127 callbacks suppressed Do the ratelimit check only if the signal is unhandled. Fixes: ("arm64: use private ratelimit state along with show_unhandled_signals") Cc: Vladimir Murzin <Vladimir.Murzin@arm.com> Signed-off-by:

Suzuki K. Poulose <suzuki.poulose@arm.com> Signed-off-by:

Catalin Marinas <catalin.marinas@arm.com>

arch/arm64/kernel/traps.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -335,7 +335,7 @@ asmlinkage void __exception do_undefinstr(struct pt_regs *regs)
		if (call_undef_hook(regs) == 0)
		return;

		if (show_unhandled_signals_ratelimited() && unhandled_signal(current, SIGILL)) {
		if (unhandled_signal(current, SIGILL) && show_unhandled_signals_ratelimited()) {
		pr_info("%s[%d]: undefined instruction: pc=%p\n",
		current->comm, task_pid_nr(current), pc);
		dump_instr(KERN_INFO, regs);

arch/arm64/mm/fault.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -115,7 +115,7 @@ static void __do_user_fault(struct task_struct *tsk, unsigned long addr,
		{
		struct siginfo si;

		if (show_unhandled_signals_ratelimited() && unhandled_signal(tsk, sig)) {
		if (unhandled_signal(tsk, sig) && show_unhandled_signals_ratelimited()) {
		pr_info("%s[%d]: unhandled %s (%d) at 0x%08lx, esr 0x%03x\n",
		tsk->comm, task_pid_nr(tsk), fault_name(esr), sig,
		addr, esr);

Admin message