Commit f86e5bf8 authored Mar 23, 2020 by Sagi Grimberg Committed by Christoph Hellwig Mar 31, 2020

nvme-tcp: don't poll a non-live queue



In error recovery we might be removing the queue so check we
can actually poll before we do.

Reported-by: Mark Wunderlich <mark.wunderlich@intel.com>
Tested-by: Mark Wunderlich <mark.wunderlich@intel.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 25e5cb78

drivers/nvme/host/tcp.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -2299,6 +2299,9 @@ static int nvme_tcp_poll(struct blk_mq_hw_ctx *hctx)
		struct nvme_tcp_queue *queue = hctx->driver_data;
		struct sock *sk = queue->sock->sk;

		if (!test_bit(NVME_TCP_Q_LIVE, &queue->flags))
		return 0;

		if (sk_can_busy_loop(sk) && skb_queue_empty_lockless(&sk->sk_receive_queue))
		sk_busy_loop(sk, true);
		nvme_tcp_try_recv(queue);

Admin message