Commit f84f8f93 authored Oct 18, 2019 by James Smart Committed by Martin K. Petersen Oct 24, 2019

scsi: lpfc: fix coverity error of dereference after null check

Log message conditional upon vport being NULL dereferences vport to
determine log verbose setting.

Changed to use lpfc_print_log which uses phba to determine the active log
verbose setting.

Fixes: 43bfea1b ("scsi: lpfc: Fix coverity errors on NULL pointer checks")
Link: https://lore.kernel.org/r/20191018211832.7917-8-jsmart2021@gmail.com


Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 91a52b61

drivers/scsi/lpfc/lpfc_els.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -4292,7 +4292,7 @@ lpfc_cmpl_els_rsp(struct lpfc_hba phba, struct lpfc_iocbq cmdiocb,
	irsp = &rspiocb->iocb;		irsp = &rspiocb->iocb;

	if (!vport) {		if (!vport) {
	lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS,		lpfc_printf_log(phba, KERN_ERR, LOG_ELS,
	"3177 ELS response failed\n");		"3177 ELS response failed\n");
	goto out;		goto out;
	}		}

Admin message