Commit f80ec966 authored by Keith Busch's avatar Keith Busch Committed by Jens Axboe
Browse files

nvme: Limit command retries 



Many controller implementations will return errors to commands that will
not succeed, but without the DNR bit set. The driver previously retried
these commands an unlimited number of times until the command timeout
has exceeded, which takes an unnecessarilly long period of time.

This patch limits the number of retries a command can have, defaulting
to 5, but is user tunable at load or runtime.

The struct request's 'retries' field is used to track the number of
retries attempted. This is in contrast with scsi's use of this field,
which indicates how many retries are allowed.

Signed-off-by: default avatarKeith Busch <keith.busch@intel.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 7a649737

drivers/nvme/host/core.c

+5 −0
Original line number Diff line number Diff line
@@ -48,6 +48,11 @@ unsigned char shutdown_timeout = 5; 
module_param(shutdown_timeout, byte, 0644);

MODULE_PARM_DESC(shutdown_timeout, "timeout in seconds for controller shutdown");



unsigned int nvme_max_retries = 5;

module_param_named(max_retries, nvme_max_retries, uint, 0644);

MODULE_PARM_DESC(max_retries, "max number of retries a command may have");

EXPORT_SYMBOL_GPL(nvme_max_retries);



static int nvme_major;

module_param(nvme_major, int, 0);

drivers/nvme/host/nvme.h

+4 −1
Original line number Diff line number Diff line
@@ -41,6 +41,8 @@ extern unsigned char shutdown_timeout; 
#define NVME_DEFAULT_KATO	5

#define NVME_KATO_GRACE		10



extern unsigned int nvme_max_retries;



enum {

	NVME_NS_LBA		= 0,

	NVME_NS_LIGHTNVM	= 1,
@@ -239,7 +241,8 @@ static inline int nvme_error_status(u16 status) 
static inline bool nvme_req_needs_retry(struct request *req, u16 status)

{

	return !(status & NVME_SC_DNR || blk_noretry_request(req)) &&

		(jiffies - req->start_time) < req->timeout;

		(jiffies - req->start_time) < req->timeout &&

		req->retries < nvme_max_retries;

}



void nvme_cancel_request(struct request *req, void *data, bool reserved);

drivers/nvme/host/pci.c

+6 −0
Original line number Diff line number Diff line
@@ -310,6 +310,11 @@ static int nvme_init_iod(struct request *rq, unsigned size, 
	iod->npages = -1;

	iod->nents = 0;

	iod->length = size;



	if (!(rq->cmd_flags & REQ_DONTPREP)) {

		rq->retries = 0;

		rq->cmd_flags |= REQ_DONTPREP;

	}

	return 0;

}
@@ -623,6 +628,7 @@ static void nvme_complete_rq(struct request *req) 


	if (unlikely(req->errors)) {

		if (nvme_req_needs_retry(req, req->errors)) {

			req->retries++;

			nvme_requeue_req(req);

			return;

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE