Commit f80c1d57 authored Mar 02, 2016 by Bhumika Goyal Committed by Greg Kroah-Hartman Mar 11, 2016

Staging: rtl8192u: Replace memset with eth_broadcast_addr



Use eth_broadcast_addr to assign the broadcast address to the given
address array instead of memset when the second argument is a broacast
address 0xff. ETH_ALEN is a macro with value 6, so 6 is treated as
ETH_ALEN if it is the third argument of memset.

Done using coccinelle.
@@
expression e;
@@
- memset(e,\(0xff\|0xFF\|255\),\(ETH_ALEN\|6\));
+ eth_broadcast_addr(e);

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7288cadc

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -342,9 +342,9 @@ inline struct sk_buff ieee80211_probe_req(struct ieee80211_device ieee)
		req->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_PROBE_REQ);
		req->header.duration_id = 0; /* FIXME: is this OK? */

		memset(req->header.addr1, 0xff, ETH_ALEN);
		eth_broadcast_addr(req->header.addr1);
		memcpy(req->header.addr2, ieee->dev->dev_addr, ETH_ALEN);
		memset(req->header.addr3, 0xff, ETH_ALEN);
		eth_broadcast_addr(req->header.addr3);

		tag = (u8 *) skb_put(skb,len+2+rate_len);

Admin message