Commit f7fb538a authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf tools: Recalc total periods using top-level entries in hierarchy 



When hierarchy mode is enabled, each entry in a hierarchy level shares
the period.  IOW an upper level entry's period is the sum of lower level
entries.  Thus perf uses only one of them to calculate the total period
of hists.  It was lowest-level (leaf) entries but it has a problem when
it comes to filters.

If a filter is applied, entries in the same level will be filtered or
not.  But upper level entries still have period of their sum including
filtered one.  So total sum of upper level entries will not be same as
sum of lower level entries.

This resulted in entries having more than 100% of overhead and it can be
produced using perf top with filter(s).

Reported-and-Tested-by: default avatarJiri Olsa <jolsa@kernel.org>
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1457531222-18130-8-git-send-email-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 86e3ee52

tools/perf/util/hist.c

+34 −10
Original line number Diff line number Diff line
@@ -1453,6 +1453,31 @@ void hists__inc_stats(struct hists *hists, struct hist_entry *h) 
	hists->stats.total_period += h->stat.period;

}



static void hierarchy_recalc_total_periods(struct hists *hists)

{

	struct rb_node *node;

	struct hist_entry *he;



	node = rb_first(&hists->entries);



	hists->stats.total_period = 0;

	hists->stats.total_non_filtered_period = 0;



	/*

	 * recalculate total period using top-level entries only

	 * since lower level entries only see non-filtered entries

	 * but upper level entries have sum of both entries.

	 */

	while (node) {

		he = rb_entry(node, struct hist_entry, rb_node);

		node = rb_next(node);



		hists->stats.total_period += he->stat.period;

		if (!he->filtered)

			hists->stats.total_non_filtered_period += he->stat.period;

	}

}



static void hierarchy_insert_output_entry(struct rb_root *root,

					  struct hist_entry *he)

{
@@ -1518,11 +1543,6 @@ static void hists__hierarchy_output_resort(struct hists *hists, 
			continue;

		}



		/* only update stat for leaf entries to avoid duplication */

		hists__inc_stats(hists, he);

		if (!he->filtered)

			hists__calc_col_len(hists, he);



		if (!use_callchain)

			continue;
@@ -1602,11 +1622,13 @@ static void output_resort(struct hists *hists, struct ui_progress *prog, 
	hists__reset_col_len(hists);



	if (symbol_conf.report_hierarchy) {

		return hists__hierarchy_output_resort(hists, prog,

		hists__hierarchy_output_resort(hists, prog,

					       &hists->entries_collapsed,

					       &hists->entries,

					       min_callchain_hits,

					       use_callchain);

		hierarchy_recalc_total_periods(hists);

		return;

	}



	if (sort__need_collapse)
@@ -1927,6 +1949,8 @@ static void hists__filter_hierarchy(struct hists *hists, int type, const void *a 
		}

	}



	hierarchy_recalc_total_periods(hists);



	/*

	 * resort output after applying a new filter since filter in a lower

	 * hierarchy can change periods in a upper hierarchy.

CRA Git | Maintained and supported by SUSTech CRA and CCSE