Commit f7db2beb authored Dec 18, 2018 by Colin Ian King Committed by David S. Miller Dec 18, 2018

vxge: ensure data0 is initialized in when fetching firmware version information

Currently variable data0 is not being initialized so a garbage value is
being passed to vxge_hw_vpath_fw_api and this value is being written to
the rts_access_steer_data0 register. There are other occurrances where
data0 is being initialized to zero (e.g. in function
vxge_hw_upgrade_read_version) so I think it makes sense to ensure data0
is initialized likewise to 0.

Detected by CoverityScan, CID#140696 ("Uninitialized scalar variable")

Fixes: 8424e00d ("vxge: serialize access to steering control register")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d81c5054

drivers/net/ethernet/neterion/vxge/vxge-config.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -808,7 +808,7 @@ __vxge_hw_vpath_fw_ver_get(struct __vxge_hw_virtualpath *vpath,
		struct vxge_hw_device_date *fw_date = &hw_info->fw_date;
		struct vxge_hw_device_version *flash_version = &hw_info->flash_version;
		struct vxge_hw_device_date *flash_date = &hw_info->flash_date;
		u64 data0, data1 = 0, steer_ctrl = 0;
		u64 data0 = 0, data1 = 0, steer_ctrl = 0;
		enum vxge_hw_status status;

		status = vxge_hw_vpath_fw_api(vpath,

Admin message