Commit f7da0bdb authored Jul 24, 2012 by Axel Lin Committed by Linus Walleij Aug 05, 2012

gpio: msic: Fix calculating register address in msic_gpio_to_oreg()



In the case offset is 20 ... 23, the equation to get the register should be:
        INTEL_MSIC_GPIO1HV0CTLO - offset + 20

With above equation, we can get below mapping between offset and the register:
        offset is 20: INTEL_MSIC_GPIO1HV0CTLO
        offset is 21: INTEL_MSIC_GPIO1HV1CTLO
        offset is 22: INTEL_MSIC_GPIO1HV2CTLO
        offset is 23: INTEL_MSIC_GPIO1HV3CTLO

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 8abdd2d2

drivers/gpio/gpio-msic.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -99,7 +99,7 @@ static int msic_gpio_to_oreg(unsigned offset)
		if (offset < 20)
		return INTEL_MSIC_GPIO0HV0CTLO - offset + 16;

		return INTEL_MSIC_GPIO1HV0CTLO + offset + 20;
		return INTEL_MSIC_GPIO1HV0CTLO - offset + 20;
		}

		static int msic_gpio_direction_input(struct gpio_chip *chip, unsigned offset)

Admin message