Commit f7d31e65 authored Apr 24, 2020 by Jon Doron Committed by Paolo Bonzini Jun 01, 2020

x86/kvm/hyper-v: Explicitly align hcall param for kvm_hyperv_exit



The problem the patch is trying to address is the fact that 'struct
kvm_hyperv_exit' has different layout on when compiling in 32 and 64 bit
modes.

In 64-bit mode the default alignment boundary is 64 bits thus
forcing extra gaps after 'type' and 'msr' but in 32-bit mode the
boundary is at 32 bits thus no extra gaps.

This is an issue as even when the kernel is 64 bit, the userspace using
the interface can be both 32 and 64 bit but the same 32 bit userspace has
to work with 32 bit kernel.

The issue is fixed by forcing the 64 bit layout, this leads to ABI
change for 32 bit builds and while we are obviously breaking '32 bit
userspace with 32 bit kernel' case, we're fixing the '32 bit userspace
with 64 bit kernel' one.

As the interface has no (known) users and 32 bit KVM is rather baroque
nowadays, this seems like a reasonable decision.

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Jon Doron <arilou@gmail.com>
Message-Id: <20200424113746.3473563-2-arilou@gmail.com>
Reviewed-by: Roman Kagan <rvkagan@yandex-team.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 27461da3

Documentation/virt/kvm/api.rst

+2 −0

Original line number	Diff line number	Diff line
		@@ -5067,9 +5067,11 @@ EOI was received.
		#define KVM_EXIT_HYPERV_SYNIC 1
		#define KVM_EXIT_HYPERV_HCALL 2
		__u32 type;
		__u32 pad1;
		union {
		struct {
		__u32 msr;
		__u32 pad2;
		__u64 control;
		__u64 evt_page;
		__u64 msg_page;

include/uapi/linux/kvm.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -189,9 +189,11 @@ struct kvm_hyperv_exit {
		#define KVM_EXIT_HYPERV_SYNIC 1
		#define KVM_EXIT_HYPERV_HCALL 2
		__u32 type;
		__u32 pad1;
		union {
		struct {
		__u32 msr;
		__u32 pad2;
		__u64 control;
		__u64 evt_page;
		__u64 msg_page;

Admin message