Commit f7c83e2e authored Oct 10, 2008 by Jonathan Brassow Committed by Alasdair G Kergon Oct 10, 2008

dm raid1: kcopyd should stop on error if errors handled



dm-raid1 is setting the 'DM_KCOPYD_IGNORE_ERROR' flag unconditionally
when assigning kcopyd work.  kcopyd is responsible for copying an
assigned section of disk to one or more other disks.  The
'DM_KCOPYD_IGNORE_ERROR' flag affects kcopyd in the following way:

When not set:
kcopyd will immediately stop the copy operation when an error is
encountered.

When set:
kcopyd will try to proceed regardless of errors and try to continue
copying any remaining amount.

Since dm-raid1 tracks regions of the address space that are (or
are not) in sync and it now has the ability to handle these
errors, we can safely enable this optimization.  This optimization
is conditional on whether mirror error handling has been enabled.

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

parent 6680073d

drivers/md/dm-raid1.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -842,7 +842,9 @@ static int recover(struct mirror_set ms, struct region reg)
		}

		/* hand to kcopyd */
		if (!errors_handled(ms))
		set_bit(DM_KCOPYD_IGNORE_ERROR, &flags);

		r = dm_kcopyd_copy(ms->kcopyd_client, &from, ms->nr_mirrors - 1, to,
		flags, recovery_complete, reg);

Admin message