Commit f794dc23 authored Sep 09, 2019 by Xin Long Committed by David S. Miller Sep 10, 2019

sctp: fix the missing put_user when dumping transport thresholds



This issue causes SCTP_PEER_ADDR_THLDS sockopt not to be able to dump
a transport thresholds info.

Fix it by adding 'goto' put_user in sctp_getsockopt_paddr_thresholds.

Fixes: 8add543e ("sctp: add SCTP_FUTURE_ASSOC for SCTP_PEER_ADDR_THLDS sockopt")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d4d6ec6d

net/sctp/socket.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -7173,7 +7173,7 @@ static int sctp_getsockopt_paddr_thresholds(struct sock *sk,
		val.spt_pathmaxrxt = trans->pathmaxrxt;
		val.spt_pathpfthld = trans->pf_retrans;

		return 0;
		goto out;
		}

		asoc = sctp_id2assoc(sk, val.spt_assoc_id);
		@@ -7191,6 +7191,7 @@ static int sctp_getsockopt_paddr_thresholds(struct sock *sk,
		val.spt_pathmaxrxt = sp->pathmaxrxt;
		}

		out:
		if (put_user(len, optlen) \|\| copy_to_user(optval, &val, len))
		return -EFAULT;

Admin message