Commit f78d4032 authored Jun 15, 2020 by Wolfram Sang Committed by Wolfram Sang Jun 19, 2020

drm: encoder_slave: fix refcouting error for modules



module_put() balances try_module_get(), not request_module(). Fix the
error path to match that.

Fixes: 2066facc ("drm/kms: slave encoder interface.")
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Wolfram Sang <wsa@kernel.org>

parent b3a9e3b9

drivers/gpu/drm/drm_encoder_slave.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -84,7 +84,7 @@ int drm_i2c_encoder_init(struct drm_device *dev,

		err = encoder_drv->encoder_init(client, dev, encoder);
		if (err)
		goto fail_unregister;
		goto fail_module_put;

		if (info->platform_data)
		encoder->slave_funcs->set_config(&encoder->base,
		@@ -92,9 +92,10 @@ int drm_i2c_encoder_init(struct drm_device *dev,

		return 0;

		fail_module_put:
		module_put(module);
		fail_unregister:
		i2c_unregister_device(client);
		module_put(module);
		fail:
		return err;
		}

Admin message