Commit f77f3036 authored May 29, 2018 by Leon Romanovsky Committed by Doug Ledford Jun 01, 2018

RDMA/mlx4: Catch FW<->SW misalignment without machine crash



Any steering QP is supposed be above steering_qp_base,
see function mlx4_ib_steer_qp_alloc() for it, however in case
of misalignment between SW and FW, this qp_base can be wrong.

Use WARN() to catch such situation without killing the machine.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 367d2f07

drivers/infiniband/hw/mlx4/main.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -3017,7 +3017,10 @@ void mlx4_ib_steer_qp_free(struct mlx4_ib_dev *dev, u32 qpn, int count)
		dev->steering_support != MLX4_STEERING_MODE_DEVICE_MANAGED)
		return;

		BUG_ON(qpn < dev->steer_qpn_base);
		if (WARN(qpn < dev->steer_qpn_base, "qpn = %u, steer_qpn_base = %u\n",
		qpn, dev->steer_qpn_base))
		/* not supposed to be here */
		return;

		bitmap_release_region(dev->ib_uc_qpns_bitmap,
		qpn - dev->steer_qpn_base,

Admin message