Commit f7655229 authored by Al Viro's avatar Al Viro Committed by David S. Miller
Browse files

[IPV4]: ip_rt_redirect() annotations 



The first 4 arguments of ip_rt_redirect() are net-endian.  Annotated.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9e12bb22

include/net/route.h

+2 −2
Original line number Diff line number Diff line
@@ -109,8 +109,8 @@ extern struct ip_rt_acct *ip_rt_acct; 


struct in_device;

extern int		ip_rt_init(void);

extern void		ip_rt_redirect(u32 old_gw, u32 dst, u32 new_gw,

				       u32 src, struct net_device *dev);

extern void		ip_rt_redirect(__be32 old_gw, __be32 dst, __be32 new_gw,

				       __be32 src, struct net_device *dev);

extern void		ip_rt_advice(struct rtable **rp, int advice);

extern void		rt_cache_flush(int how);

extern int		__ip_route_output_key(struct rtable **, const struct flowi *flp);

net/ipv4/route.c

+3 −3
Original line number Diff line number Diff line
@@ -1118,13 +1118,13 @@ static void rt_del(unsigned hash, struct rtable *rt) 
	spin_unlock_bh(rt_hash_lock_addr(hash));

}



void ip_rt_redirect(u32 old_gw, u32 daddr, u32 new_gw,

		    u32 saddr, struct net_device *dev)

void ip_rt_redirect(__be32 old_gw, __be32 daddr, __be32 new_gw,

		    __be32 saddr, struct net_device *dev)

{

	int i, k;

	struct in_device *in_dev = in_dev_get(dev);

	struct rtable *rth, **rthp;

	u32  skeys[2] = { saddr, 0 };

	__be32  skeys[2] = { saddr, 0 };

	int  ikeys[2] = { dev->ifindex, 0 };

	struct netevent_redirect netevent;

CRA Git | Maintained and supported by SUSTech CRA and CCSE